Skip to content

Comments

Update supported versions#1832

Merged
fhemberger merged 10 commits intomasterfrom
fix/package-manager
Oct 28, 2018
Merged

Update supported versions#1832
fhemberger merged 10 commits intomasterfrom
fix/package-manager

Conversation

@fhemberger
Copy link
Contributor

@fhemberger fhemberger commented Oct 10, 2018

Updated supported versions, as mentioned in #1831.

However, I noticed that the two documents seem to be drifting apart in other sections. So we should really think about how we want to handle this in the future. That's also the reason I didn't update all distros.

/cc @bnb @rvagg Any ideas on how to proceed?

@fhemberger fhemberger requested review from bnb and rvagg October 10, 2018 08:18
vsemozhetbyt
vsemozhetbyt reviewed Oct 10, 2018
View reviewed changes
locale/en/download/package-manager.md Outdated
**Available architectures:**

* **i386** (32-bit)
* **i386** (32-bit)—**not available for Node.js 10 and later**
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Oct 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: let's use m-dash or hyphen with spaces consistently (compare additions below)?

refack
refack reviewed Oct 10, 2018
View reviewed changes
locale/en/download/package-manager.md Outdated
* **Ubuntu 14.04 LTS** (Trusty Tahr)
* **Ubuntu 14.04 LTS** (Trusty Tahr) - **not available for Node.js 10 and later**
* **Ubuntu 16.04 LTS** (Xenial Xerus)
* **Ubuntu 17.10** (Artful Aardvark)
Copy link
Contributor

@refack refack Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

17.10 went EOL, so it not supported anymore...

@refack
Copy link
Contributor

refack commented Oct 10, 2018

I'm kinda in favor of just linking instead of C&P content (for example next week we're gonna have node v11 as well)...
Maybe just leave a line about supported (as in not EOL RE nodejs/Release#359) node versions on supported distro versions.

@fhemberger
Copy link
Contributor Author

fhemberger commented Oct 25, 2018 •
edited
Loading

Okay, I removed the whole Debian/Ubuntu/RHEL section and replaced it with a link to the NodeSource repo.

We still need translations/updated for those pages:

  • @nodejs/nodejs-es
  • @nodejs/nodejs-ja
  • @nodejs/nodejs-ko
  • @nodejs/nodejs-uk
  • @nodejs/nodejs-cn
  • @nodejs/nodejs-tw

@fhemberger fhemberger added the i18n Issues/PRs related to the Website Internationalisation label Oct 25, 2018
@academo
Copy link
Contributor

academo commented Oct 25, 2018

I can help with the Spanish translation

academo
academo suggested changes Oct 25, 2018
View reviewed changes
@academo @fhemberger
Update locale/es/download/package-manager.md
8689e10 
Co-Authored-By: fhemberger <mail@frederic-hemberger.de>
@fhemberger
Copy link
Contributor Author

fhemberger commented Oct 25, 2018

@academo Thanks!

@ZYSzys ZYSzys mentioned this pull request Oct 25, 2018
Merged
@suensummit suensummit mentioned this pull request Oct 25, 2018
Merged
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 25, 2018

uk/download/package-manager.md has not translated text, it seems it's just a placeholder. It can be deleted or replaced by the en/download/package-manager.md.

@fhemberger
Copy link
Contributor Author

fhemberger commented Oct 26, 2018

Great, only two more to go.

@e-jigsaw e-jigsaw mentioned this pull request Oct 26, 2018
Merged
@fhemberger
Copy link
Contributor Author

fhemberger commented Oct 28, 2018

I also added missing Android and Solus descriptions to es/ja/ko (untranslated).
Those can be translated in a separate PR as well, as I think it's more important to have the content up to date.

@fhemberger fhemberger merged commit aeb8963 into master Oct 28, 2018
@fhemberger fhemberger deleted the fix/package-manager branch October 28, 2018 03:38
@fhemberger
Copy link
Contributor Author

fhemberger commented Oct 28, 2018

Thank you all for your help!

@yous yous mentioned this pull request Oct 28, 2018
Closed
@fhemberger fhemberger mentioned this pull request Oct 31, 2018
Closed
@taggon taggon mentioned this pull request Jan 10, 2019
Merged
ghost pushed a commit that referenced this pull request Feb 3, 2019
@taggon
Korean translation for package-manager.md (#1979)
f0c1874 
This PR fixes some missing Korean translations in #1832.
Ref：nodejs/nodejs-ko#763
@richardlau richardlau mentioned this pull request Nov 12, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 30, 2020
Merged
@NOUIY NOUIY mentioned this pull request Jun 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvagg rvagg Awaiting requested review from rvagg

@bnb bnb Awaiting requested review from bnb

3 more reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@academo academo academo requested changes

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n Issues/PRs related to the Website Internationalisation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fhemberger @refack @academo @vsemozhetbyt @suensummit @ZYSzys @e-jigsaw